hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-456) Problems with dfs.name.edits.dirs as URI
Date Thu, 02 Jul 2009 22:37:47 GMT

    [ https://issues.apache.org/jira/browse/HDFS-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726715#action_12726715
] 

Konstantin Shvachko commented on HDFS-456:
------------------------------------------

Raghu is right, my comment #1 an #3 are not related to the edits patch. This should be taken
care in a different jira.
I ran tests on  Linux and did not see failures, except for TestBackupNode, which is a known
issue.
Please do not forget to past unit test and test-patch results before committing is Hudson
is off.
I did not look deep into the problem, but I thought we are calling getCanonicalPath() to read
edits files, which adds the drive letter. So may be the solution should be to call toURI()
on the path before anything else. This should convert the path (even if it is a win path)
to correct uri, but if the path is already a URI it will remain the same. Then we can start
analyzing the scheme and the authority.

> Problems with dfs.name.edits.dirs as URI
> ----------------------------------------
>
>                 Key: HDFS-456
>                 URL: https://issues.apache.org/jira/browse/HDFS-456
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Shvachko
>            Assignee: Luca Telloli
>             Fix For: 0.21.0
>
>
> There are several problems with recent commit of HDFS-396.
> # It does not work with default configuration "file:///". Throws {{IllegalArgumentException}}.
> # *ALL* hdfs tests fail on Windows because "C:\mypath" is treated as an illegal URI.
Backward compatibility is not provided.
> # {{IllegalArgumentException}} should not be thrown within hdfs code because it is a
{{RuntimException}}. We should throw {{IOException}} instead. This was recently discussed
in another jira.
> # Why do we commit patches without running unit tests and test-patch? This is the minimum
requirement for a patch to qualify as committable, right?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message