hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-461) Analyzing file size distribution.
Date Thu, 02 Jul 2009 21:51:47 GMT

    [ https://issues.apache.org/jira/browse/HDFS-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726698#action_12726698
] 

Jakob Homan commented on HDFS-461:
----------------------------------

Looks good.  How was it to implement the processor?  I think I see some places where I can
improve the interface for those extending the oiv.  

Concerns:
* The Javadoc is great, but since oiv is a user-facing tool, most of the documentation should
go into the forrest docs on the oiv page.
* Currently the tool only counts inodes, not inodes-under-construction. If this is intended,
it should be documented.
* Command line processor uses equalsIgnoreCase, which is different than the other options,
which just use the equals method.  Should all use the same comparison method, and I believe
case sensitivity is standard.
* There doesn't appear to be any documentation in the usage section that is printed to the
terminal as to the step or maxSize options.

Nits:
* modulo division will result in every 1000001, 2000001, 3000001 being reported, which is
reasonable, but multiples of one million might be more standard.




> Analyzing file size distribution.
> ---------------------------------
>
>                 Key: HDFS-461
>                 URL: https://issues.apache.org/jira/browse/HDFS-461
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: test, tools
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.21.0
>
>         Attachments: OIV-FileDistr.patch
>
>
> This is a tool for analyzing file size distribution in HDFS using a modified Offline
Image Viewer tool.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message