hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luca Telloli (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HDFS-456) Problems with dfs.name.edits.dirs as URI
Date Sun, 05 Jul 2009 13:28:15 GMT

     [ https://issues.apache.org/jira/browse/HDFS-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Luca Telloli updated HDFS-456:
------------------------------

    Attachment: HDFS-456.patch

Attaching a patch for this issue. 

- All URI are now built using 
new File(name).getCanonicalPath().toURI() 
as Konstantin suggested. 
- LOG.error messages have been updated 
- from the messages above I understand that IllegalArgumentException is not an issue for this
patch, correct? 

I see the queue for HDFS on hudson is not working, so I won't submit the patch. I'm running
the test locally and I'll post the output afterwards. 

> Problems with dfs.name.edits.dirs as URI
> ----------------------------------------
>
>                 Key: HDFS-456
>                 URL: https://issues.apache.org/jira/browse/HDFS-456
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Shvachko
>            Assignee: Luca Telloli
>             Fix For: 0.21.0
>
>         Attachments: HDFS-456.patch
>
>
> There are several problems with recent commit of HDFS-396.
> # It does not work with default configuration "file:///". Throws {{IllegalArgumentException}}.
> # *ALL* hdfs tests fail on Windows because "C:\mypath" is treated as an illegal URI.
Backward compatibility is not provided.
> # {{IllegalArgumentException}} should not be thrown within hdfs code because it is a
{{RuntimException}}. We should throw {{IOException}} instead. This was recently discussed
in another jira.
> # Why do we commit patches without running unit tests and test-patch? This is the minimum
requirement for a patch to qualify as committable, right?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message