hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luca Telloli (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-456) Problems with dfs.name.edits.dirs as URI
Date Wed, 01 Jul 2009 17:19:47 GMT

    [ https://issues.apache.org/jira/browse/HDFS-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726136#action_12726136
] 

Luca Telloli commented on HDFS-456:
-----------------------------------

Mahadev, yes, tests are probably failing on Windows since the patch has been tested thoroughly
under Linux and MacOsX.
I have requested a virtual machine with windows installed, since at the moment I don't have
any windows machine available. 

Konstantin, I'd like to understand better what you mean with your #1. Do you want to assign
root "/" as a Storage Directory? 
Also, I would remove #4 from your comments, I think it's unfair, incorrect, and not useful
to the issue. I assume that a developer is not requested to have any possible environment
ready to test the patch locally; instead, the testing system (hudson?) should take care of
it. 

> Problems with dfs.name.edits.dirs as URI
> ----------------------------------------
>
>                 Key: HDFS-456
>                 URL: https://issues.apache.org/jira/browse/HDFS-456
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Shvachko
>            Assignee: Luca Telloli
>             Fix For: 0.21.0
>
>
> There are several problems with recent commit of HDFS-396.
> # It does not work with default configuration "file:///". Throws {{IllegalArgumentException}}.
> # *ALL* hdfs tests fail on Windows because "C:\mypath" is treated as an illegal URI.
Backward compatibility is not provided.
> # {{IllegalArgumentException}} should not be thrown within hdfs code because it is a
{{RuntimException}}. We should throw {{IOException}} instead. This was recently discussed
in another jira.
> # Why do we commit patches without running unit tests and test-patch? This is the minimum
requirement for a patch to qualify as committable, right?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message