hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-512) Set block id as the key to Block
Date Fri, 31 Jul 2009 20:56:14 GMT

    [ https://issues.apache.org/jira/browse/HDFS-512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737702#action_12737702
] 

Tsz Wo (Nicholas), SZE commented on HDFS-512:
---------------------------------------------

Hairong, if my concerns are carefully considered, I won't veto the changes although the changes
are still very dangerous.

I suggest to keep WILDCARD_STAMP and use it for sanity check as shown below.
{code}
//Block
  public boolean equals(Object o) {
    ...
    final Block that = (Block)o;
    if (this.generationStamp != that.generationStamp && that.generationStamp != WILDCARD_STAMP)
{
      throw new IllegalArgumentException(..);
    }
    return ...
  }
{code}

> Set block id as the key to Block
> --------------------------------
>
>                 Key: HDFS-512
>                 URL: https://issues.apache.org/jira/browse/HDFS-512
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.21.0
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>             Fix For: 0.21.0
>
>         Attachments: blockKey.patch
>
>
> Currently the key to Block is block id + generation stamp. I would propose to change
it to be only block id. This is based on the following properties of the dfs cluster:
> 1. On each datanode only one replica of block exists. Therefore there is only one generation
of a block.
> 2. NameNode has only one entry for a block in its blocks map.
> With this change, search for a block/replica's meta information is easier since most
of the time we know a block's id but may not know its generation stamp.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message