hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghu Angadi (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-397) Incorporate storage directories into EditLogFileInput/Output streams
Date Mon, 13 Jul 2009 19:07:14 GMT

    [ https://issues.apache.org/jira/browse/HDFS-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730464#action_12730464

Raghu Angadi commented on HDFS-397:

Regd 1) : What about 'STORAGE_JSPOOL_DIR' which points to a different directory from 'current'.
JSPOOL_FILE also 'happens' to be same but intention of original author might have been to
be able change. 
We should remove these constants if these are not sued.

bq. I assumed it's correct since it passed the unit tests correctly.

hmm.. I don't think that is sufficient or wise. When I program I would like to know what I
am doing and why it is correct at every line.

> Have a look for instance to line 1497 and following. 
Is it for the latest patch attached there? I am asking this mainly so that I don't have go
through the big patch for HDFS-311.

> Incorporate storage directories into EditLogFileInput/Output streams
> --------------------------------------------------------------------
>                 Key: HDFS-397
>                 URL: https://issues.apache.org/jira/browse/HDFS-397
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Luca Telloli
>            Assignee: Luca Telloli
>         Attachments: HADOOP-6001.patch, HADOOP-6001.patch, HADOOP-6001.patch, HDFS-397.patch

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message