hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luca Telloli (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-456) Problems with dfs.name.edits.dirs as URI
Date Tue, 14 Jul 2009 10:15:14 GMT

    [ https://issues.apache.org/jira/browse/HDFS-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730767#action_12730767
] 

Luca Telloli commented on HDFS-456:
-----------------------------------

I run the tests: 
{noformat}
     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
     [exec] 
{noformat}

Results on core tests are one failing test: 
{noformat}
    [junit] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 122.279 sec
    [junit] Test org.apache.hadoop.cli.TestHDFSCLI FAILED
{noformat}
with the following error: 
{noformat}
2009-07-14 10:40:01,804 INFO  cli.TestCLI (TestCLI.java:displayResults(180)) -
2009-07-14 10:40:01,804 INFO  cli.TestCLI (TestCLI.java:displayResults(184)) - Summary results:
2009-07-14 10:40:01,804 INFO  cli.TestCLI (TestCLI.java:displayResults(185)) - ----------------------------------
2009-07-14 10:40:01,805 INFO  cli.TestCLI (TestCLI.java:displayResults(205)) -           
    Testing mode: test2009-07-14 10:40:01,805 INFO  cli.TestCLI (TestCLI.java:displayResults(206))
-
2009-07-14 10:40:01,805 INFO  cli.TestCLI (TestCLI.java:displayResults(207)) -           
  Overall result: --- FAIL ---2009-07-14 10:40:01,805 INFO  cli.TestCLI (TestCLI.java:displayResults(215))
-                # Tests pass: 621 (99%)
2009-07-14 10:40:01,805 INFO  cli.TestCLI (TestCLI.java:displayResults(217)) -           
    # Tests fail: 2 (0%)2009-07-14 10:40:01,806 INFO  cli.TestCLI (TestCLI.java:displayResults(221))
-          # Validations done: 1819 (each test may 
do multiple validations)2009-07-14 10:40:01,806 INFO  cli.TestCLI (TestCLI.java:displayResults(224))
-
2009-07-14 10:40:01,806 INFO  cli.TestCLI (TestCLI.java:displayResults(225)) - Failing tests:2009-07-14
10:40:01,806 INFO  cli.TestCLI (TestCLI.java:displayResults(226)) - --------------
2009-07-14 10:40:01,806 INFO  cli.TestCLI (TestCLI.java:displayResults(232)) - 557: help:
help for rm2009-07-14 10:40:01,806 INFO  cli.TestCLI (TestCLI.java:displayResults(232)) -
558: help: help for rmr
2009-07-14 10:40:01,806 INFO  cli.TestCLI (TestCLI.java:displayResults(242)) -
{noformat}

> Problems with dfs.name.edits.dirs as URI
> ----------------------------------------
>
>                 Key: HDFS-456
>                 URL: https://issues.apache.org/jira/browse/HDFS-456
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Shvachko
>            Assignee: Luca Telloli
>             Fix For: 0.21.0
>
>         Attachments: HDFS-456.patch, HDFS-456.patch, HDFS-456.patch
>
>
> There are several problems with recent commit of HDFS-396.
> # It does not work with default configuration "file:///". Throws {{IllegalArgumentException}}.
> # *ALL* hdfs tests fail on Windows because "C:\mypath" is treated as an illegal URI.
Backward compatibility is not provided.
> # {{IllegalArgumentException}} should not be thrown within hdfs code because it is a
{{RuntimException}}. We should throw {{IOException}} instead. This was recently discussed
in another jira.
> # Why do we commit patches without running unit tests and test-patch? This is the minimum
requirement for a patch to qualify as committable, right?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message