hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-505) Convert the file including 10 minutes run's tests into the test harness test suite
Date Fri, 24 Jul 2009 20:49:14 GMT

    [ https://issues.apache.org/jira/browse/HDFS-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735153#action_12735153

Jakob Homan commented on HDFS-505:

In my opinion, having the 10-minute-tests defined in an external file is a feature, not a
bug.  It makes it easy to quickly see what's in the suite quickly and easily update it without
touching code.  The set membership seems to be a matter of configuration, which should go
into a separate file, rather than code, which should go into a test suite.  Tagging had seemed
like a good solution because a test's membership into the set can be viewed as metadata, but
if we don't really have annotation-type tagging, it may not be worth it.
I had hoped to use tagging because I wanted to tag individual tests from a test suite rather
than running all the tests in the suite, as we have to do now.  But it sounds like that's
not possible, even creating a new test suite.  Or am I wrong about that? 
If it's not possible to include individual tests into the 10min suite via annotation-type
tagging, and if we're going to have to do something tricky/clever to get the test suite approach
to work (as Cos mentions above), I'd rather keep the flat files.

> Convert the file including 10 minutes run's tests into the test harness test suite
> ----------------------------------------------------------------------------------
>                 Key: HDFS-505
>                 URL: https://issues.apache.org/jira/browse/HDFS-505
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: build, test
>            Reporter: Konstantin Boudnik
> This issue is created to track the conversion of external testlist for 10 minutes tests
into JUnit test suite.
> It would be consistent through the bigger Hadoop project to have 10 minutes tests to
be collected in a JUnit's test suite instead of an external file (as of now). 
> The reason is simple: with the file we'd have two points of maintenance: tests source
code and one an auxiliary text files. Besides, a general approach is to use JUnit's suites
for tagging purposes, thus having a suite here would be more uniform.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message