[ https://issues.apache.org/jira/browse/HDFS-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728293#action_12728293
]
Jakob Homan commented on HDFS-461:
----------------------------------
Looks good. +1 with two minor quibbles:
* On line 25 of your patch, the console help should be wrapped to fit with the rest of the
text, currently it runs very long:
{noformat}
* XML: This processor creates an XML document with all elements of
the fsimage enumerated, suitable for further analysis by XML
tools.
* FileDistribution: This processor analyzes the file size
distribution in the image.
-maxSize specifies the range [0, maxSize] of file sizes to be analyzed (128GB by default).
-step defines the granularity of the distribution. (2MB by default)
{noformat}
* In the forrest docs, the new processor is referred to as a visitor, which is an implementation
detail that shouldn't leak out into userland.
> Analyzing file size distribution.
> ---------------------------------
>
> Key: HDFS-461
> URL: https://issues.apache.org/jira/browse/HDFS-461
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: test, tools
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.21.0
>
> Attachments: OIV-FileDistr.patch, OIV-FileDistr.patch
>
>
> This is a tool for analyzing file size distribution in HDFS using a modified Offline
Image Viewer tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
|