hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghu Angadi (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-456) Problems with dfs.name.edits.dirs as URI
Date Wed, 01 Jul 2009 18:19:47 GMT

    [ https://issues.apache.org/jira/browse/HDFS-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726165#action_12726165
] 

Raghu Angadi commented on HDFS-456:
-----------------------------------


Luca, (1) in Konstantin's comment is mostly not related to HDFS-356. I think tests were done
for the patch but it is a known issue that we don't test for windows but generally would like
to fix windows bugs when reported.

I think you can test this on Linux, but by passing in a Windows path for namenode directory
("C:\test"). It may not be necessary for you find a windows machine.

Mostly "C:" is making is an illegal URI. We need to have a fix for windows paths :
a. Does URI class or utilities help in handling windows path? Otherwise, we need treat windows
paths specially.. something like what firefox does ("c:/" in url bar is an error, but "c:\"
gets mapped to "file:///c:/").

Some time back we used to ask ourselves "What would windows do?" question more often. For
this important change, we didn't. This is just another example of how there is "simple change"...
there is a tough balance between how much we want to ask a contributor to tweak, test, and
refine a patch and making it smooth and simple to contribute. just my 2 cents.




> Problems with dfs.name.edits.dirs as URI
> ----------------------------------------
>
>                 Key: HDFS-456
>                 URL: https://issues.apache.org/jira/browse/HDFS-456
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Shvachko
>            Assignee: Luca Telloli
>             Fix For: 0.21.0
>
>
> There are several problems with recent commit of HDFS-396.
> # It does not work with default configuration "file:///". Throws {{IllegalArgumentException}}.
> # *ALL* hdfs tests fail on Windows because "C:\mypath" is treated as an illegal URI.
Backward compatibility is not provided.
> # {{IllegalArgumentException}} should not be thrown within hdfs code because it is a
{{RuntimException}}. We should throw {{IOException}} instead. This was recently discussed
in another jira.
> # Why do we commit patches without running unit tests and test-patch? This is the minimum
requirement for a patch to qualify as committable, right?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message