From hdfs-dev-return-40856-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Mon Jan 13 16:57:33 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 026D618064E for ; Mon, 13 Jan 2020 17:57:32 +0100 (CET) Received: (qmail 25373 invoked by uid 500); 13 Jan 2020 16:57:30 -0000 Mailing-List: contact hdfs-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-dev@hadoop.apache.org Received: (qmail 25066 invoked by uid 99); 13 Jan 2020 16:57:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jan 2020 16:57:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B9B1D180624 for ; Mon, 13 Jan 2020 16:57:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.952 X-Spam-Level: X-Spam-Status: No, score=0.952 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.2, KAM_INFOUSMEBIZ=0.75, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=ahussein-me.20150623.gappssmtp.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id O5cA-pcKk97L for ; Mon, 13 Jan 2020 16:57:26 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::d42; helo=mail-io1-xd42.google.com; envelope-from=a@ahussein.me; receiver= Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 3E9907DE01 for ; Mon, 13 Jan 2020 16:57:26 +0000 (UTC) Received: by mail-io1-xd42.google.com with SMTP id h8so10580461iob.2 for ; Mon, 13 Jan 2020 08:57:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ahussein-me.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Tv6Tb84AM48v0B/Mk4GBa815FuVm2hWdgA1Rd6ji/ww=; b=VU+My5SvIgLf7fImjOT6kvlDTHydALRZkCd+2IxO3ZPGrAF4p3wpYZyzOgcvB2KOJy 106A4VqNxVy0gp9NiACiFH7Gp+pAWE4I7qKjgA84xIUwrp5SRF5JQ7wUUfIFvDQdR3C4 d420NycQ7t2yExeAJVouv9eCUp1UBlWrmP7uoo41s1pR16kG1iO/FnlBhBxbuqTDz8Yk ivXNiJvx85LZz3U5E3HSJin5TU7z07RSL/WIkH2k/7SuOMlCXvsTrA5K1VjIj4i1xFMx gJvcVjeBzK/hvFV1iIVAu5vQdWYccibSH8XYAzcQsMXZk59BqLzuHxp0paKa7cPLIlPM Slsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Tv6Tb84AM48v0B/Mk4GBa815FuVm2hWdgA1Rd6ji/ww=; b=m8tAzTW1BY34KSkXWMZF14gD68/5Cx+g4o3Jz6YMraHFLUoNqXaYMCG8pOw15uqJKz +hMwLMMHJw8Zf9FEMuJJMHSARrBIKgiAu6/HP3LPUIe/GZAGLgRe7MOSzKILsJnDPB2K AVnGT1e4l1Wd0om9IXD5qAND0eVRUtbNO0TMHeTy7kKZls0lb6dOn2ND+6skGTBC/Szl n05JDt/DtoIF9mSUu+cJNHksJRYnSrGzYUfS1LCKxZTN5MkQVAz2+e1+miIRi6ZLuvTI Q9+eE+X/1wDi72zQy/nc7VBHc6KsKQf9DZDm9sdaqf55wyJGyS26sIdSSTe8891IQf1j VYGg== X-Gm-Message-State: APjAAAWk7r3RMuya0NbOZ/iNkCG9hZUGWI6+7+F+UI/sSy1zk4kJGOfH LyEfWRZ3aMc92RpkwIuFIthRLDkWRonwSDYgSaJeYw== X-Google-Smtp-Source: APXvYqzNKf2rnpPJYQqTwlM6ZIuzA1LAeYqUXv/qb9TDLOG6jX2ZCq/SJo4MMkRB6VmlpFxVQ35730rKSb/MpCOiXZU= X-Received: by 2002:a05:6638:6a6:: with SMTP id d6mr15106139jad.132.1578934644909; Mon, 13 Jan 2020 08:57:24 -0800 (PST) MIME-Version: 1.0 References: <1968798093.10688734.1578591207636.ref@mail.yahoo.com> <1968798093.10688734.1578591207636@mail.yahoo.com> In-Reply-To: From: Ahmed Hussein Date: Mon, 13 Jan 2020 10:57:14 -0600 Message-ID: Subject: Re: [DISCUSS] Guidelines for Code cleanup JIRAs To: Wei-Chiu Chuang Cc: "epayne@apache.org" , Yarn-dev , Hdfs-dev , Hadoop Common Content-Type: multipart/alternative; boundary="000000000000a26f91059c085e5b" --000000000000a26f91059c085e5b Content-Type: text/plain; charset="UTF-8" +1 Can we also make sure to add a label for the code cleanup Jiras? At least, this will make it easy to search and filter jiras. On Mon, Jan 13, 2020 at 7:24 AM Wei-Chiu Chuang wrote: > +1 > > On Thu, Jan 9, 2020 at 9:33 AM epayne@apache.org > wrote: > > > There was some discussion on > > https://issues.apache.org/jira/browse/YARN-9052 > > about concerns surrounding the costs/benefits of code cleanup JIRAs. This > > email > > is to get the discussion going within a wider audience. > > > > The positive points for code cleanup JIRAs: > > - Clean up tech debt > > - Make code more readable > > - Make code more maintainable > > - Make code more performant > > > > The concerns regarding code cleanup JIRAs are as follows: > > - If the changes only go into trunk, then contributors and committers > > trying to > > backport to prior releases will have to create and test multiple patch > > versions. > > - Some have voiced concerns that code cleanup JIRAs may not be tested as > > thoroughly as features and bug fixes because functionality is not > > supposed to > > change. > > - Any patches awaiting review that are touching the same code will have > to > > be > > redone, re-tested, and re-reviewed. > > - JIRAs that are opened for code cleanup and not worked on right away > tend > > to > > clutter up the JIRA space. > > > > Here are my opinions: > > - Code changes of any kind force a non-trivial amount of overhead for > other > > developers. For code cleanup JIRAs, sometimes the usability, > > maintainability, > > and performance is worth the overhead (as in the case of YARN-9052). > > - Before opening any JIRA, please always consider whether or not the > added > > usability will outweigh the added pain you are causing other > developers. > > - If you believe the benefits outweigh the costs, please backport the > > changes > > yourself to all active lines. My preference is to port all the way back > > to 2.10. > > - Please don't run code analysis tools and then open many JIRAs that > > document > > those findings. That activity does not put any thought into this > > cost-benefit > > analysis. > > > > Thanks everyone. I'm looking forward to your thoughts. I appreciate all > > you do > > for the open source community and it is always a pleasure to work with > you. > > -Eric Payne > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org > > For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org > > > > > --000000000000a26f91059c085e5b--