hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jianfei Jiang (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-13001) Testcase improvement for DFSAdmin
Date Tue, 09 Jan 2018 10:46:00 GMT
Jianfei Jiang created HDFS-13001:
------------------------------------

             Summary: Testcase improvement for DFSAdmin
                 Key: HDFS-13001
                 URL: https://issues.apache.org/jira/browse/HDFS-13001
             Project: Hadoop HDFS
          Issue Type: Sub-task
    Affects Versions: 3.0.0, 2.9.0
            Reporter: Jianfei Jiang
            Assignee: Jianfei Jiang
            Priority: Minor


Testcase improvement for DFSAdmin command. The commands should be tested under following environments:
(1) Both Namenode are up online
(2) NN1 is off offline and NN2 is up online
(3) NN1 is up online and NN2 is down offline
(4) Both Namenode are down offline
The testcases can be improved.

Testcases can be improved like code below.

{code:java}
  private void testExecuteDFSAdminCommand(int nnIndex, String[] command,
      String message) throws Exception {
    setUpHaCluster(false);
    switch (nnIndex) {
      case 0:
        cluster.getDfsCluster().shutdownNameNode(0);
        cluster.getDfsCluster().transitionToActive(1);
        break;
      case 1:
        cluster.getDfsCluster().shutdownNameNode(1);
        cluster.getDfsCluster().transitionToActive(0);
        break;
      case 2:
        cluster.getDfsCluster().shutdownNameNode(0);
        cluster.getDfsCluster().shutdownNameNode(1);
        break;
      default:

    }
    int exitCode = admin.run(command);
    if (nnIndex != 2) {
      assertEquals(err.toString().trim(), 0, exitCode);
      assertOutputMatches(message + newLine);
    } else {
      assertNotEquals(err.toString().trim(), 0, exitCode);
      assertOutputNotMatches(message + newLine);
    }
  }
{code}




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org


Mime
View raw message