hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anu Engineer (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-12238) Ozone: Add valid trace ID check in sendCommandAsync
Date Tue, 01 Aug 2017 19:46:02 GMT
Anu Engineer created HDFS-12238:
-----------------------------------

             Summary: Ozone: Add valid trace ID check in sendCommandAsync
                 Key: HDFS-12238
                 URL: https://issues.apache.org/jira/browse/HDFS-12238
             Project: Hadoop HDFS
          Issue Type: Sub-task
          Components: ozone
    Affects Versions: HDFS-7240
            Reporter: Anu Engineer


In the function {{XceiverClientHandler#sendCommandAsync}} we should add a check 
{code}
   if(StringUtils.isEmpty(request.getTraceID())) {
      throw new IllegalArgumentException("Invalid trace ID");
    }
{code}

To ensure that ozone clients always send a valid trace ID. However, when you do that a set
of current tests that do add a valid trace ID will fail. So we need to fix these tests too.

{code}
  TestContainerMetrics.testContainerMetrics
  TestOzoneContainer.testBothGetandPutSmallFile
  TestOzoneContainer.testCloseContainer
  TestOzoneContainer.testOzoneContainerViaDataNode
  TestOzoneContainer.testXcieverClientAsync
  TestOzoneContainer.testCreateOzoneContainer
  TestOzoneContainer.testDeleteContainer
  TestContainerServer.testClientServer
  TestContainerServer.testClientServerWithContainerDispatcher
  TestKeys.testPutAndGetKeyWithDnRestart
{code}

This is based on a comment from [~vagarychen] in HDFS-11580.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org


Mime
View raw message