hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Allen Wittenauer ...@effectivemachines.com>
Subject Re: [VOTE] Release Apache Hadoop 2.7.3 RC1
Date Wed, 17 Aug 2016 15:11:04 GMT

	Touching the audit log is *extremely* dangerous from a compatibility perspective.  It is
easily the most machine processed log in Hadoop (with the second likely being the fsck log).
 In particular, this comment tells me that we are almost certainly going to break users:

	"Some audit logs ( for non-ACE failures ) will go missing. So this change needs to be marked
as Incompatible, for heads-up."

	If that means what I think it means (the ordering of checks is going to make previously logged
errors disappear in lieu of other, new messages showing up first), that is going to cause
massive problems for users who are looking for a particular entry. Worse, while the JIRA was
marked incompatible, there are absolutely zero hints to end users (changes file, release notes)
that this could potentially break their universe without digging into the comments of said
JIRA.  That's not a heads up, that's a landmine.

	It's also arguable that this is actually a bug fix.  A lot of the assumptions made in that
JIRA about the audit logs original intent are completely wrong. Better yet, a lot of the justification
is around another unmarked, incompatible change that was introduced in the 2.x timeline.

	Even if one disagrees and still views this as a bug fix:  it's still an incompatible change.
 Users are justifiably angry when we don't warn them about breakages and this is a great example
of that.  

> On Aug 17, 2016, at 6:15 AM, Junping Du <jdu@hortonworks.com> wrote:
> 
> From my quick understanding, HDFS-9395 is more like a bug fix and improvement for audit
logging instead of incompatible changes. We mark incompatible probably because the audit log
behavior could be corrected/updated in some exception cases. I think it still belongs to 2.7.3
scope. 
> Kuhu and Kihwal, any comments here?
> 
> 
> Thanks,
> 
> Junping 
> ________________________________________
> From: Allen Wittenauer <aw@effectivemachines.com>
> Sent: Wednesday, August 17, 2016 5:29 AM
> To: common-dev@hadoop.apache.org
> Cc: hdfs-dev@hadoop.apache.org; yarn-dev@hadoop.apache.org; mapreduce-dev@hadoop.apache.org
> Subject: Re: [VOTE] Release Apache Hadoop 2.7.3 RC1
> 
> -1
> 
> HDFS-9395 is an incompatible change:
> 
> a) Why is not marked as such in the changes file?
> b) Why is an incompatible change in a micro release, much less a minor?
> c) Where is the release note for this change?
> 
> 
>> On Aug 12, 2016, at 9:45 AM, Vinod Kumar Vavilapalli <vinodkv@apache.org> wrote:
>> 
>> Hi all,
>> 
>> I've created a release candidate RC1 for Apache Hadoop 2.7.3.
>> 
>> As discussed before, this is the next maintenance release to follow up 2.7.2.
>> 
>> The RC is available for validation at: http://home.apache.org/~vinodkv/hadoop-2.7.3-RC1/
<http://home.apache.org/~vinodkv/hadoop-2.7.3-RC0/>
>> 
>> The RC tag in git is: release-2.7.3-RC1
>> 
>> The maven artifacts are available via repository.apache.org <http://repository.apache.org/>
at https://repository.apache.org/content/repositories/orgapachehadoop-1045/ <https://repository.apache.org/content/repositories/orgapachehadoop-1045/>
>> 
>> The release-notes are inside the tar-balls at location hadoop-common-project/hadoop-common/src/main/docs/releasenotes.html.
I hosted this at home.apache.org/~vinodkv/hadoop-2.7.3-RC1/releasenotes.html <http://people.apache.org/~vinodkv/hadoop-2.7.2-RC1/releasenotes.html>
for your quick perusal.
>> 
>> As you may have noted,
>> - few issues with RC0 forced a RC1 [1]
>> - a very long fix-cycle for the License & Notice issues (HADOOP-12893) caused
2.7.3 (along with every other Hadoop release) to slip by quite a bit. This release's related
discussion thread is linked below: [2].
>> 
>> Please try the release and vote; the vote will run for the usual 5 days.
>> 
>> Thanks,
>> Vinod
>> 
>> [1] [VOTE] Release Apache Hadoop 2.7.3 RC0: https://www.mail-archive.com/hdfs-dev%40hadoop.apache.org/index.html#26106
<https://www.mail-archive.com/hdfs-dev%40hadoop.apache.org/index.html#26106>
>> [2]: 2.7.3 release plan: https://www.mail-archive.com/hdfs-dev%40hadoop.apache.org/msg24439.html
<http://markmail.org/thread/6yv2fyrs4jlepmmr>
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: yarn-dev-help@hadoop.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org


Mime
View raw message