Mailing-List: contact hdfs-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Subject: Re: Why there are so many revert operations on trunk?
MIME-Version: 1.0
From: Jitendra Pandey <jitendra@hortonworks.com>
To: Chris Douglas <cdouglas@apache.org>
CC: Junping Du <jdu@hortonworks.com>, "Aaron T. Myers" <atm@cloudera.com>,
	Andrew Wang <andrew.wang@cloudera.com>, "common-dev@hadoop.apache.org"
	<common-dev@hadoop.apache.org>, "hdfs-dev@hadoop.apache.org"
	<hdfs-dev@hadoop.apache.org>, "mapreduce-dev@hadoop.apache.org"
	<mapreduce-dev@hadoop.apache.org>, "yarn-dev@hadoop.apache.org"
	<yarn-dev@hadoop.apache.org>
Thread-Topic: Why there are so many revert operations on trunk?
Thread-Index: AQHRv/1V6he6qAueg06qIPCRr0jnCp/dCn6A//+PVhaAAIjpAIAACpwA
Date: Mon, 6 Jun 2016 17:51:02 +0000
Message-ID: <D9E35924-90C2-48C2-BA87-853BA8EF2DEC@hortonworks.com>
References: <1465223008024.45875@hortonworks.com>
 <CA+4052nvqDw-1JC6HtkS5R1phHXzS1MwTxL2-KMJaFC+DJhr2w@mail.gmail.com>
 <1465231154205.38002@hortonworks.com>
 <CACO5Y4zGzBKORetSSoc5FrbYqfX5XEXgrhm=JHU9SLgCMKdFsQ@mail.gmail.com>
In-Reply-To: <CACO5Y4zGzBKORetSSoc5FrbYqfX5XEXgrhm=JHU9SLgCMKdFsQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [192.175.27.10]
x-source-routing-agent: Processed
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <86D793146CACE44389A6E82775219919@exch080.serverpod.net>
Content-Transfer-Encoding: quoted-printable
archived-at: Mon, 06 Jun 2016 17:51:13 -0000

Colin raised the -1 demanding a design document. The document was added the=
 very next day. There were constructive discussions on the design. There wa=
s a demand for listenable future or futures with callback, which was accept=
ed to accommodate. Rest of the work having been completed, there was no nee=
d to revert. Andrew=92s objection was primarily against releasing in 2.8 wi=
thout the aforementioned change in API, which is reasonable and, IMO, it sh=
ould be possible to make the above improvement within 2.8 timeline.=20

On Jun 6, 2016, at 10:13 AM, Chris Douglas <cdouglas@apache.org> wrote:

> Reading through HDFS-9924, a request for a design doc- and a -1 on
> committing to trunk- was raised in mid-May, but commits to trunk
> continued. Why is that? Shouldn't this have paused while the details
> were discussed? Branching is neutral to the pace of feature
> development, but consensus on the result is required. Working through
> possibilities in a branch- or in multiple branches- seems like a
> reasonable way to determine which approach has support and code to
> back it.
>=20
> Reverting code is not "illegal"; the feature will be in/out of any
> release by appealing to bylaws. Our rules exist to facilitate
> consensus, not declare it a fiat accompli.
>=20
> An RM only exists by creating an RC. Someone can declare themselves
> Grand Marshall of trunk and stomp around in a fancy hat, but it
> doesn't affect anything. -C
>=20
>=20
> On Mon, Jun 6, 2016 at 9:36 AM, Junping Du <jdu@hortonworks.com> wrote:
>> Thanks Aaron for pointing it out. I didn't see any consensus on HDFS-992=
4 so I think we should bring it here with broader audiences for more discus=
sions.
>>=20
>> I saw several very bad practices here:
>>=20
>> 1. committer (no need to say who) revert all commits from trunk without =
making consensus with all related contributors/committers.
>>=20
>> 2. Someone's comments on feature branch are very misleading... If I didn=
't remember wrong, feature development doesn't have to go through feature b=
ranch which is just an optional process. This creative process of feature b=
ranch and branch committer - I believe the intention is trying to accelerat=
e features development but not to slow them down.
>>=20
>> 3. Someone (again, no need to say who) seems to claim himself as RM for =
trunk. I don't think we need any RM for trunk. Even for RM of 3.0.0-alpha, =
I think we need someone else who demonstrates he/she is more responsible, w=
ork hardly and carefully and open communication with all community. Only th=
rough this, the success of Hadoop in age of 3.0 are guranteed.
>>=20
>>=20
>> Thanks,
>>=20
>>=20
>> Junping
>>=20
>>=20
>> ________________________________
>> From: Aaron T. Myers <atm@cloudera.com>
>> Sent: Monday, June 06, 2016 4:46 PM
>> To: Junping Du
>> Cc: Andrew Wang; common-dev@hadoop.apache.org; hdfs-dev@hadoop.apache.or=
g; mapreduce-dev@hadoop.apache.org; yarn-dev@hadoop.apache.org
>> Subject: Re: Why there are so many revert operations on trunk?
>>=20
>> Junping,
>>=20
>> All of this is being discussed on HDFS-9924. Suggest you follow the conv=
ersation there.
>>=20
>> --
>> Aaron T. Myers
>> Software Engineer, Cloudera
>>=20
>> On Mon, Jun 6, 2016 at 7:20 AM, Junping Du <jdu@hortonworks.com<mailto:j=
du@hortonworks.com>> wrote:
>> Hi Andrew,
>>=20
>>     I just noticed you revert 8 commits on trunk last Friday:
>>=20
>> HADOOP-13226
>>=20
>> HDFS-10430
>>=20
>> HDFS-10431
>>=20
>> HDFS-10390
>>=20
>> HADOOP-13168
>>=20
>> HDFS-10390
>>=20
>> HADOOP-13168
>>=20
>> HDFS-10346
>>=20
>> HADOOP-12957
>>=20
>> HDFS-10224
>>=20
>>   And I didn't see you have any comments on JIRA or email discussion bef=
ore you did this. I don't think we are legally allowed to do this even as c=
ommitter/PMC member. Can you explain what's your intention to do this?
>>=20
>>   BTW, thanks Nicolas to revert all these "illegal" revert operations.
>>=20
>>=20
>>=20
>> Thanks,
>>=20
>>=20
>> Junping
>>=20
>=20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
>=20
>=20


---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org