hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingliang Liu (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-10533) Make DistCpOptions class immutable
Date Wed, 15 Jun 2016 20:52:09 GMT
Mingliang Liu created HDFS-10533:
------------------------------------

             Summary: Make DistCpOptions class immutable
                 Key: HDFS-10533
                 URL: https://issues.apache.org/jira/browse/HDFS-10533
             Project: Hadoop HDFS
          Issue Type: Improvement
          Components: distcp
    Affects Versions: 3.0.0-alpha1
            Reporter: Mingliang Liu
            Assignee: Mingliang Liu


Currently the {{DistCpOptions}} class encapsulates all DistCp options, which may be set from
command-line (via the {{OptionsParser}}) or may be set manually (eg construct an instance
and call setters). As there are multiple option fields and more (e.g. [HDFS-9868], [HDFS-10314])
to add, validating them can be cumbersome. Ideally, the {{DistCpOptions}} object should be
immutable. The benefits are:
# {{DistCpOptions}} is simple and easier to use and share, plus it scales well
# validation is automatic, e.g. manually constructed {{DistCpOptions}} gets validated before
usage
# validation error message is well-defined which does not depend on the order of setters

This jira is to track the effort of making the {{DistCpOptions}} immutable by using a Builder
pattern for creation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org


Mime
View raw message