Mailing-List: contact hdfs-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 24 May 2016 23:18:12 +0000 (UTC)
From: "Tianyin Xu (JIRA)" <jira@apache.org>
To: hdfs-dev@hadoop.apache.org
Message-ID: <JIRA.12972556.1464131833000.281966.1464131892831@Atlassian.JIRA>
In-Reply-To: <JIRA.12972556.1464131833000@Atlassian.JIRA>
References: <JIRA.12972556.1464131833000@Atlassian.JIRA> <JIRA.12972556.1464131833476@arcas>
Subject: [jira] [Created] (HDFS-10455) Logging the username when deny the
 setOwner operation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 24 May 2016 23:18:17 -0000

Tianyin Xu created HDFS-10455:
---------------------------------

             Summary: Logging the username when deny the setOwner operation
                 Key: HDFS-10455
                 URL: https://issues.apache.org/jira/browse/HDFS-10455
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: namenode
    Affects Versions: 2.7.2
            Reporter: Tianyin Xu
            Priority: Minor
         Attachments: HDFS-10455.000.patch

The attached patch appends the user name in the logging when the setOwner operation is denied due to insufficient permissions on this user (based on his/her name). 

The same practice is used in {{FSPermissionChecker}} such as {{checkOwner()}} and {{checkSuperuserPrivilege()}}.

{code:title=FSDirAttrOp.java|borderStyle=solid}
       if (!pc.isSuperUser()) {
         if (username != null && !pc.getUser().equals(username)) {
-          throw new AccessControlException("Non-super user cannot change owner");
+          throw new AccessControlException("User " + pc.getUser()
+              + " is not a super user (non-super user cannot change owner).");
         }
         if (group != null && !pc.containsGroup(group)) {
-          throw new AccessControlException("User does not belong to " + group);
+          throw new AccessControlException("User " + pc.getUser()
+              + " does not belong to " + group);
         }

{code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org