hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Pallas (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-10189) PacketResponder toString is built incorrectly
Date Mon, 21 Mar 2016 19:52:25 GMT
Joe Pallas created HDFS-10189:
---------------------------------

             Summary: PacketResponder toString is built incorrectly
                 Key: HDFS-10189
                 URL: https://issues.apache.org/jira/browse/HDFS-10189
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: datanode
    Affects Versions: 2.7.1
            Reporter: Joe Pallas
            Priority: Minor


The constructor for {{BlockReceiver.PacketResponder}} says
{code}
      final StringBuilder b = new StringBuilder(getClass().getSimpleName())
          .append(": ").append(block).append(", type=").append(type);
      if (type != PacketResponderType.HAS_DOWNSTREAM_IN_PIPELINE) {
        b.append(", downstreams=").append(downstreams.length)
            .append(":").append(Arrays.asList(downstreams));
      }
{code}
So it includes the list of downstreams only when it has no downstreams.  The {{if}} test should
be for equality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message