hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Clampffer (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-9712) libhdfs++: Reimplement Status object as a normal struct
Date Wed, 27 Jan 2016 21:36:39 GMT
James Clampffer created HDFS-9712:

             Summary: libhdfs++: Reimplement Status object as a normal struct
                 Key: HDFS-9712
                 URL: https://issues.apache.org/jira/browse/HDFS-9712
             Project: Hadoop HDFS
          Issue Type: Sub-task
            Reporter: James Clampffer
            Assignee: James Clampffer

hdfs::Status is doing all sorts of reinterpret casts on a block of memory referenced by a
char *.  Using a char *, casting to a wider type, and dereferencing can cause fun alignment

As far as I can tell that data layout in status can be boiled down to:
class Status {
  int code;
  std::string msg;

This avoids doing manual memcopies in the copy ctor and delete[]s in the dtor.  It will also
get rid of boilerplate null checks and casts.

This message was sent by Atlassian JIRA

View raw message