hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiao Chen (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-9590) NPE in Storage#unlock
Date Mon, 21 Dec 2015 22:45:46 GMT
Xiao Chen created HDFS-9590:
-------------------------------

             Summary: NPE in Storage#unlock
                 Key: HDFS-9590
                 URL: https://issues.apache.org/jira/browse/HDFS-9590
             Project: Hadoop HDFS
          Issue Type: Bug
            Reporter: Xiao Chen
            Assignee: Xiao Chen


The code looks to be possible to have race conditions in multiple-threaded runs.
{code}
    public void unlock() throws IOException {
      if (this.lock == null)
        return;
      this.lock.release();
      lock.channel().close();
      lock = null;
    }
{code}
This is called in a handful of places, and I don't see any protection. Shall we add some synchronization
mechanism? Not sure if I missed any design assumptions here.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message