hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HDFS-6290) File is not closed in OfflineImageViewerPB#run()
Date Wed, 19 Aug 2015 23:21:46 GMT

     [ https://issues.apache.org/jira/browse/HDFS-6290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Haohui Mai resolved HDFS-6290.
------------------------------
    Resolution: Won't Fix

I don't think this is worth fixing as the life cycle of the file closely matches the life
cycle of the process. The file will be automatically closed when the process exits.

> File is not closed in OfflineImageViewerPB#run()
> ------------------------------------------------
>
>                 Key: HDFS-6290
>                 URL: https://issues.apache.org/jira/browse/HDFS-6290
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: tools
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>       } else if (processor.equals("XML")) {
>         new PBImageXmlWriter(conf, out).visit(new RandomAccessFile(inputFile,
>             "r"));
> {code}
> The RandomAccessFile instance should be closed before the method returns.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message