From hdfs-dev-return-19562-apmail-hadoop-hdfs-dev-archive=hadoop.apache.org@hadoop.apache.org Fri Jul 31 06:11:08 2015 Return-Path: X-Original-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9224518899 for ; Fri, 31 Jul 2015 06:11:08 +0000 (UTC) Received: (qmail 28937 invoked by uid 500); 31 Jul 2015 06:11:04 -0000 Delivered-To: apmail-hadoop-hdfs-dev-archive@hadoop.apache.org Received: (qmail 28836 invoked by uid 500); 31 Jul 2015 06:11:04 -0000 Mailing-List: contact hdfs-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-dev@hadoop.apache.org Delivered-To: mailing list hdfs-dev@hadoop.apache.org Received: (qmail 28819 invoked by uid 99); 31 Jul 2015 06:11:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Jul 2015 06:11:04 +0000 Date: Fri, 31 Jul 2015 06:11:04 +0000 (UTC) From: "songwanging (JIRA)" To: hdfs-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (HDFS-8840) Inconsistent log level practice MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 songwanging created HDFS-8840: --------------------------------- Summary: Inconsistent log level practice Key: HDFS-8840 URL: https://issues.apache.org/jira/browse/HDFS-8840 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.7.1, 2.5.2, 2.5.1, 2.6.0 Reporter: songwanging Priority: Minor In method "checkLogsAvailableForRead()" of class: hadoop-2.7.1-src\hadoop-hdfs-project\hadoop-hdfs\src\main\java\org\apache\hadoop\hdfs\server\namenode\ha\BootstrapStandby.java The log level is not correct, after checking "LOG.isDebugEnabled()", we should use "LOG.debug(msg, e);", while now we use " LOG.fatal(msg, e);". Log level is inconsistent. the source code of this method is: private boolean checkLogsAvailableForRead(FSImage image, long imageTxId, long curTxIdOnOtherNode) { ... } catch (IOException e) { ... if (LOG.isDebugEnabled()) { LOG.fatal(msg, e); } else { LOG.fatal(msg); } return false; } } -- This message was sent by Atlassian JIRA (v6.3.4#6332)