Return-Path: X-Original-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CF4DE101EE for ; Fri, 2 Jan 2015 04:04:14 +0000 (UTC) Received: (qmail 94445 invoked by uid 500); 2 Jan 2015 04:04:13 -0000 Delivered-To: apmail-hadoop-hdfs-dev-archive@hadoop.apache.org Received: (qmail 94248 invoked by uid 500); 2 Jan 2015 04:04:13 -0000 Mailing-List: contact hdfs-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-dev@hadoop.apache.org Delivered-To: mailing list hdfs-dev@hadoop.apache.org Received: (qmail 94009 invoked by uid 99); 2 Jan 2015 04:04:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jan 2015 04:04:13 +0000 Date: Fri, 2 Jan 2015 04:04:13 +0000 (UTC) From: "Ted Yu (JIRA)" To: hdfs-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (HDFS-7493) removedDst should be checked against null in finally block of FSDirRenameOp#unprotectedRenameTo() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved HDFS-7493. -------------------------- Resolution: Duplicate Dup of HDFS-7538 > removedDst should be checked against null in finally block of FSDirRenameOp#unprotectedRenameTo() > ------------------------------------------------------------------------------------------------- > > Key: HDFS-7493 > URL: https://issues.apache.org/jira/browse/HDFS-7493 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Ted Yu > Priority: Minor > > {code} > removedDst = dstIIP.getLastINode(); > undoRemoveDst = true; > {code} > If removedDst is null, the following code in finally block may result in NPE: > {code} > if (dstParent.isDirectory() && > dstParent.asDirectory().isWithSnapshot()) { > dstParent.asDirectory().undoRename4DstParent(removedDst, > dstIIP.getLatestSnapshotId()); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)