Return-Path: X-Original-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BDFF49676 for ; Tue, 23 Dec 2014 20:42:15 +0000 (UTC) Received: (qmail 47151 invoked by uid 500); 23 Dec 2014 20:42:14 -0000 Delivered-To: apmail-hadoop-hdfs-dev-archive@hadoop.apache.org Received: (qmail 47024 invoked by uid 500); 23 Dec 2014 20:42:14 -0000 Mailing-List: contact hdfs-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-dev@hadoop.apache.org Delivered-To: mailing list hdfs-dev@hadoop.apache.org Received: (qmail 46828 invoked by uid 99); 23 Dec 2014 20:42:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Dec 2014 20:42:13 +0000 Date: Tue, 23 Dec 2014 20:42:13 +0000 (UTC) From: "Ted Yu (JIRA)" To: hdfs-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (HDFS-7567) Potential null dereference in FSEditLogLoader#applyEditLogOp() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Ted Yu created HDFS-7567: ---------------------------- Summary: Potential null dereference in FSEditLogLoader#applyEditLogOp() Key: HDFS-7567 URL: https://issues.apache.org/jira/browse/HDFS-7567 Project: Hadoop HDFS Issue Type: Bug Reporter: Ted Yu Priority: Minor {code} INodeFile oldFile = INodeFile.valueOf(iip.getLastINode(), path, true); if (oldFile != null && addCloseOp.overwrite) { ... INodeFile newFile = oldFile; ... // Update the salient file attributes. newFile.setAccessTime(addCloseOp.atime, Snapshot.CURRENT_STATE_ID); newFile.setModificationTime(addCloseOp.mtime, Snapshot.CURRENT_STATE_ID); {code} The last two lines are not protected by null check. -- This message was sent by Atlassian JIRA (v6.3.4#6332)