hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-7567) Potential null dereference in FSEditLogLoader#applyEditLogOp()
Date Tue, 23 Dec 2014 20:42:13 GMT
Ted Yu created HDFS-7567:
----------------------------

             Summary: Potential null dereference in FSEditLogLoader#applyEditLogOp()
                 Key: HDFS-7567
                 URL: https://issues.apache.org/jira/browse/HDFS-7567
             Project: Hadoop HDFS
          Issue Type: Bug
            Reporter: Ted Yu
            Priority: Minor


{code}
      INodeFile oldFile = INodeFile.valueOf(iip.getLastINode(), path, true);
      if (oldFile != null && addCloseOp.overwrite) {
...
      INodeFile newFile = oldFile;
...
      // Update the salient file attributes.
      newFile.setAccessTime(addCloseOp.atime, Snapshot.CURRENT_STATE_ID);
      newFile.setModificationTime(addCloseOp.mtime, Snapshot.CURRENT_STATE_ID);
{code}
The last two lines are not protected by null check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message