Return-Path: X-Original-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D15DB11211 for ; Thu, 7 Aug 2014 03:38:14 +0000 (UTC) Received: (qmail 60651 invoked by uid 500); 7 Aug 2014 03:38:13 -0000 Delivered-To: apmail-hadoop-hdfs-dev-archive@hadoop.apache.org Received: (qmail 59848 invoked by uid 500); 7 Aug 2014 03:38:13 -0000 Mailing-List: contact hdfs-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-dev@hadoop.apache.org Delivered-To: mailing list hdfs-dev@hadoop.apache.org Received: (qmail 59457 invoked by uid 99); 7 Aug 2014 03:38:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Aug 2014 03:38:13 +0000 Date: Thu, 7 Aug 2014 03:38:12 +0000 (UTC) From: "Arpit Agarwal (JIRA)" To: hdfs-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (HDFS-6830) BlockManager.addStorage fails when DN updates storage MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Arpit Agarwal created HDFS-6830: ----------------------------------- Summary: BlockManager.addStorage fails when DN updates storage Key: HDFS-6830 URL: https://issues.apache.org/jira/browse/HDFS-6830 Project: Hadoop HDFS Issue Type: Bug Components: namenode Affects Versions: 2.5.0 Reporter: Arpit Agarwal Assignee: Arpit Agarwal The call to {{removeStorageInfo}} is wrong because the block is still in the DatanodeStorage's list of blocks and the callee does not expect it to be. {code} } else { // The block is on the DN but belongs to a different storage. // Update our state. removeStorage(getStorageInfo(idx)); added = false; // Just updating storage. Return false. } {code} It is a very unlikely code path to hit since storage updates usually occur via incremental block reports. -- This message was sent by Atlassian JIRA (v6.2#6252)