Return-Path: X-Original-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BC11210F41 for ; Wed, 9 Jul 2014 17:41:05 +0000 (UTC) Received: (qmail 35977 invoked by uid 500); 9 Jul 2014 17:41:05 -0000 Delivered-To: apmail-hadoop-hdfs-dev-archive@hadoop.apache.org Received: (qmail 35870 invoked by uid 500); 9 Jul 2014 17:41:04 -0000 Mailing-List: contact hdfs-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-dev@hadoop.apache.org Delivered-To: mailing list hdfs-dev@hadoop.apache.org Received: (qmail 35838 invoked by uid 99); 9 Jul 2014 17:41:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jul 2014 17:41:04 +0000 Date: Wed, 9 Jul 2014 17:41:04 +0000 (UTC) From: "Kihwal Lee (JIRA)" To: hdfs-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (HDFS-6651) Deletion failure can leak inodes permanently. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Kihwal Lee created HDFS-6651: -------------------------------- Summary: Deletion failure can leak inodes permanently. Key: HDFS-6651 URL: https://issues.apache.org/jira/browse/HDFS-6651 Project: Hadoop HDFS Issue Type: Bug Reporter: Kihwal Lee Priority: Critical As discussed in HDFS-6618, if a deletion of tree fails in the middle, any collected inodes and blocks will not be removed from {{INodeMap}} and {{BlocksMap}}. Since fsimage is saved by iterating over {{INodeMap}}, the leak will persist across name node restart. Although blanked out inodes will not have reference to blocks, blocks will still refer to the inode as {{BlockCollection}}. As long as it is not null, blocks will live on. The leaked blocks from blanked out inodes will go away after restart. Options (when delete fails in the middle) - Complete the partial delete: edit log the partial delete and remove inodes and blocks. - Somehow undo the partial delete. - Check quota for snapshot diff beforehand for the whole subtree. - Ignore quota check during delete even if snapshot is present. -- This message was sent by Atlassian JIRA (v6.2#6252)