hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-6006) Remove duplicating code in FSNameSystem#getFileInfo
Date Mon, 24 Feb 2014 21:19:21 GMT
Akira AJISAKA created HDFS-6006:
-----------------------------------

             Summary: Remove duplicating code in FSNameSystem#getFileInfo
                 Key: HDFS-6006
                 URL: https://issues.apache.org/jira/browse/HDFS-6006
             Project: Hadoop HDFS
          Issue Type: Improvement
    Affects Versions: 2.3.0
            Reporter: Akira AJISAKA
            Assignee: Akira AJISAKA
            Priority: Trivial


In FSNameSystem#getFileInfo, it checks src file name two times.
{code}
    if (!DFSUtil.isValidName(src)) {
      throw new InvalidPathException("Invalid file name: " + src);
    }
    HdfsFileStatus stat = null;
    FSPermissionChecker pc = getPermissionChecker();
    checkOperation(OperationCategory.READ);
    if (!DFSUtil.isValidName(src)) {
      throw new InvalidPathException("Invalid file name: " + src);
    }
{code}
The latter should be removed.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message