hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-4797) BlockScanInfo does not override equals(..) and hashCode() consistently
Date Sat, 04 May 2013 21:40:16 GMT
Tsz Wo (Nicholas), SZE created HDFS-4797:
--------------------------------------------

             Summary: BlockScanInfo does not override equals(..) and hashCode() consistently
                 Key: HDFS-4797
                 URL: https://issues.apache.org/jira/browse/HDFS-4797
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: datanode
            Reporter: Tsz Wo (Nicholas), SZE
            Assignee: Tsz Wo (Nicholas), SZE


In the code below, equals(..) compares lastScanTime but hashCode() is computed using block
ID.  Therefore, it could have two BlockScanInfo objects which are equal but have two different
hash codes.
{code}
//BlockScanInfo
    @Override
    public int hashCode() {
      return block.hashCode();
    }
    
    @Override
    public boolean equals(Object other) {
      return other instanceof BlockScanInfo &&
             compareTo((BlockScanInfo)other) == 0;
    }
{code}


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message