Mailing-List: contact hdfs-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-dev@hadoop.apache.org
Received-SPF: unknown -allip4:64.6.108.239 (athena.apache.org: encountered
 unrecognized mechanism during SPF processing of domain of hsn@filez.com)
Message-ID: <50BE3546.7000200@filez.com>
Date: Tue, 04 Dec 2012 18:39:18 +0100
From: Radim Kolar <hsn@filez.com>
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: hdfs-dev@hadoop.apache.org
Subject: Re: profiling hdfs write path
References: <50B2908A.4070507@filez.com>
 <CADY20s5FQaxfvb4x7CcfhPF17sNq201m+mmnsD3T84vazQ8EDw@mail.gmail.com>
 <50B77C9D.6080502@filez.com>
 <CADY20s4f-YF8viCtcT9He7J+EqJizo-S_8CXFZ8FyMSjCKf42A@mail.gmail.com>
 <50BE2DB5.2030704@filez.com>
 <CADY20s7zzkDnQOGQPiDijo4t0KHwfBcWx29g0joN4otJgXigDA@mail.gmail.com>
In-Reply-To: 
 <CADY20s7zzkDnQOGQPiDijo4t0KHwfBcWx29g0joN4otJgXigDA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit


> If you're just going to insult us, please stay away. We don't need
> your help unless you're going to be constructive.
Good units tests will catch code modifications like:

from:
     long getLastByteOffsetBlock() {
       return lastByteOffsetInBlock;
     }

to

from:
     long getLastByteOffsetBlock() {
       return lastByteOffsetInBlock-1;
   }

I did 10 of such changes and about 60% were undetected.