Return-Path: X-Original-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1C1B7D5DA for ; Tue, 4 Dec 2012 17:07:50 +0000 (UTC) Received: (qmail 87074 invoked by uid 500); 4 Dec 2012 17:07:49 -0000 Delivered-To: apmail-hadoop-hdfs-dev-archive@hadoop.apache.org Received: (qmail 86691 invoked by uid 500); 4 Dec 2012 17:07:45 -0000 Mailing-List: contact hdfs-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-dev@hadoop.apache.org Delivered-To: mailing list hdfs-dev@hadoop.apache.org Received: (qmail 86661 invoked by uid 99); 4 Dec 2012 17:07:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Dec 2012 17:07:43 +0000 X-ASF-Spam-Status: No, hits=0.0 required=5.0 tests= X-Spam-Check-By: apache.org Received-SPF: unknown -allip4:64.6.108.239 (athena.apache.org: encountered unrecognized mechanism during SPF processing of domain of hsn@filez.com) Received: from [64.6.108.239] (HELO ponto.amerinoc.com) (64.6.108.239) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Dec 2012 17:07:35 +0000 Received: from fbsd9.localdomain (205.83.broadband7.iol.cz [88.102.83.205]) (authenticated bits=128) by ponto.amerinoc.com (8.14.5/8.14.5) with ESMTP id qB4H7B66004341 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 4 Dec 2012 18:07:14 +0100 (CET) (envelope-from hsn@filez.com) Received: from [127.0.0.1] ([10.0.0.1]) by fbsd9.localdomain (8.14.5/8.14.5) with ESMTP id qB4H75gZ001960 for ; Tue, 4 Dec 2012 18:07:06 +0100 (CET) (envelope-from hsn@filez.com) Message-ID: <50BE2DB5.2030704@filez.com> Date: Tue, 04 Dec 2012 18:07:01 +0100 From: Radim Kolar User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: hdfs-dev@hadoop.apache.org Subject: Re: profiling hdfs write path References: <50B2908A.4070507@filez.com> <50B77C9D.6080502@filez.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 121204-0, 04.12.2012), Outbound message X-Antivirus-Status: Clean X-Virus-Checked: Checked by ClamAV on apache.org > It is definitely buggy, it might not actually be faster, and it > probably isn't well commented. But feel free to have a go at it. thank you for your code, i got it merged with trunk. HDFS is crap code, private methods not documented at all, and unit tests are joke. I did some random code changes and some were not detected by unit tests. What methods are you using for testing?