hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colin McCabe <cmcc...@alumni.cmu.edu>
Subject Re: Release of Decompressor resources in CodecPool
Date Thu, 27 Dec 2012 21:08:59 GMT
I think that you're right.  It looks like BuiltInGzipDecompressor,
which is marked as DoNotPool, ends up owning some JNI-managed
resources.  In this case, just relying on the GC to get around to
calling the finalizer isn't a great idea.  I think you should open a
JIRA.

cheers,
Colin


On Mon, Dec 24, 2012 at 11:11 PM, lars hofhansl <lhofhansl@yahoo.com> wrote:
> In CodecPool.returnDecompressor, should we call Decompressor.end() in the "DoNotPool"
case?
> Otherwise end() is only by finalize(), which is pretty terrible.
>
> -- Lars

Mime
View raw message