hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-4029) GenerationStamp should use an AtomicLong
Date Wed, 10 Oct 2012 22:53:07 GMT
Eli Collins created HDFS-4029:

             Summary: GenerationStamp should use an AtomicLong 
                 Key: HDFS-4029
                 URL: https://issues.apache.org/jira/browse/HDFS-4029
             Project: Hadoop HDFS
          Issue Type: Sub-task
          Components: name-node
    Affects Versions: 2.0.0-alpha
            Reporter: Eli Collins
            Assignee: Eli Collins

GenerationStamp#genstamp is a volatile long. Incrementing volatiles is not thread safe, which
is currently not an issue because the only increment is done in nextStamp which is synchronized
(theoretically setStamp could race with nextStamp though that wouldn't happen given the current
code). It would be cleaner to use an AtomicLong so that genstamp itself is atomic and we don't
have to synchronize the various accesses to it.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message