hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-3802) StartupOption.name in HdfsServerConstants should be final
Date Tue, 14 Aug 2012 20:53:38 GMT
Jing Zhao created HDFS-3802:
-------------------------------

             Summary: StartupOption.name in HdfsServerConstants should be final
                 Key: HDFS-3802
                 URL: https://issues.apache.org/jira/browse/HDFS-3802
             Project: Hadoop HDFS
          Issue Type: Improvement
            Reporter: Jing Zhao
            Priority: Trivial


In HdfsServerConstants, it may be better to define StartupOption.name as final since it will
not and should not be modified after initialization. For example, in NameNode.java, the printUsage
function prints out multiple startup options' names. The modification/change of the StartupOption.name
may cause invalid usage message. Although right now there is no methods to change/set the
value of StartupOption.name, it is better to add the final keyword to make sure.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message