hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-3652) 1.x: FSEditLog failure removes the wrong edit stream when storage dirs have same name
Date Thu, 12 Jul 2012 23:16:35 GMT
Todd Lipcon created HDFS-3652:
---------------------------------

             Summary: 1.x: FSEditLog failure removes the wrong edit stream when storage dirs
have same name
                 Key: HDFS-3652
                 URL: https://issues.apache.org/jira/browse/HDFS-3652
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: name-node
    Affects Versions: 1.0.3, 1.1.0, 1.2.0
            Reporter: Todd Lipcon
            Assignee: Todd Lipcon
            Priority: Blocker


In {{FSEditLog.removeEditsForStorageDir}}, we iterate over the edits streams trying to find
the stream corresponding to a given dir. To check equality, we currently use the following
condition:
{code}
      File parentDir = getStorageDirForStream(idx);
      if (parentDir.getName().equals(sd.getRoot().getName())) {
{code}
... which is horribly incorrect. If two or more storage dirs happen to have the same terminal
path component (eg /data/1/nn and /data/2/nn) then it will pick the wrong stream(s) to remove.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message