hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andy Isaacson (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-3710) libhdfs misuses O_RDONLY/WRONLY/RDWR
Date Mon, 23 Jul 2012 23:39:33 GMT
Andy Isaacson created HDFS-3710:
-----------------------------------

             Summary: libhdfs misuses O_RDONLY/WRONLY/RDWR
                 Key: HDFS-3710
                 URL: https://issues.apache.org/jira/browse/HDFS-3710
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: libhdfs
    Affects Versions: 2.0.0-alpha
            Reporter: Andy Isaacson
            Priority: Minor


The {{O_RDONLY}} / {{O_WRONLY}} / {{O_RDWR}} macros in {{fcntl.h}} are not a bitmask; they
are an enum stored in the low bits of the flag word.  The proper way to use them is
{code}
if ((flags & O_ACCMODE) == O_RDONLY)
{code}
rather than
{code}
if ((flags & O_RDONLY) == 0)
{code}

There are many examples of this misuse in {{hdfs.c}}.

As a result of this incorrect testing, erroneous code may be accepted without error and correct
code might not work correctly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message