Return-Path: X-Original-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6B5C199F2 for ; Thu, 23 Feb 2012 01:26:13 +0000 (UTC) Received: (qmail 14543 invoked by uid 500); 23 Feb 2012 01:26:12 -0000 Delivered-To: apmail-hadoop-hdfs-dev-archive@hadoop.apache.org Received: (qmail 14454 invoked by uid 500); 23 Feb 2012 01:26:12 -0000 Mailing-List: contact hdfs-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-dev@hadoop.apache.org Delivered-To: mailing list hdfs-dev@hadoop.apache.org Received: (qmail 14390 invoked by uid 99); 23 Feb 2012 01:26:12 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Feb 2012 01:26:12 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Feb 2012 01:26:10 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 6E5B1335326 for ; Thu, 23 Feb 2012 01:25:49 +0000 (UTC) Date: Thu, 23 Feb 2012 01:25:49 +0000 (UTC) From: "Todd Lipcon (Resolved) (JIRA)" To: hdfs-dev@hadoop.apache.org Message-ID: <633681968.7538.1329960349453.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <730476679.53150.1329530285841.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Resolved] (HDFS-2973) HA: re-enable NO_ACK optimization for block deletion MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon resolved HDFS-2973. ------------------------------- Resolution: Fixed Fix Version/s: HA branch (HDFS-1623) Hadoop Flags: Reviewed Committed to HA branch (ran unit tests on this the other day) > HA: re-enable NO_ACK optimization for block deletion > ---------------------------------------------------- > > Key: HDFS-2973 > URL: https://issues.apache.org/jira/browse/HDFS-2973 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ha, name-node > Affects Versions: HA branch (HDFS-1623) > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Fix For: HA branch (HDFS-1623) > > Attachments: hdfs-2973.txt > > > Currently in trunk, when a file is removed, the deletion request is sent to the DNs with a special NO_ACK flag to indicate that they don't need to ACK the deletion. The NN itself takes care of removing the blocks from the block map, so the deletion report would be redundant. > In the HA branch, we disabled this to fix a failure in TestSafeMode -- when the active NN issues a block deletion, and the standby hasn't read the edits yet, this test case expects that it would see the block deletions. > I don't see any actual compelling reasons for this. I think we can restore the optimization and modify the test to pass. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira