hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-2896) The 2NN incorrectly daemonizes
Date Sun, 05 Feb 2012 23:22:02 GMT
The 2NN incorrectly daemonizes

                 Key: HDFS-2896
                 URL: https://issues.apache.org/jira/browse/HDFS-2896
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: name-node
    Affects Versions: 0.23.0, 0.24.0
            Reporter: Eli Collins
            Assignee: Eli Collins

The SecondaryNameNode (and Checkpointer) confuse o.a.h.u.Daemon with a Unix daemon. Per below
it intends to create a thread that never ends, but o.a.h.u.Daemon just marks a thread with
Java's Thread#setDaemon which means Java will terminate the thread when there are no more
non-daemon user threads running

    // Create a never ending deamon
    Daemon checkpointThread = new Daemon(secondary);

Perhaps they thought they were using commons Daemon. We of course don't want the 2NN to exit
unless it exits itself or is stopped explicitly. Currently it won't do this because the main
thread is not marked as a daemon thread. In any case, let's make the 2NN consistent with the
NN in this regard (exit when the RPC thread exits).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message