hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-2633) BPOfferService#isAlive is poorly named
Date Mon, 05 Dec 2011 23:01:39 GMT
BPOfferService#isAlive is poorly named

                 Key: HDFS-2633
                 URL: https://issues.apache.org/jira/browse/HDFS-2633
             Project: Hadoop HDFS
          Issue Type: Improvement
          Components: data-node
    Affects Versions: 0.23.0
            Reporter: Eli Collins
            Priority: Minor

Per HDFS-2627 the current implementation returns true even if one of the actor threads is
dead. "The only non-test use case for isAlive seems to be from BlockPoolSliceScanner and DataBlockScanner,
where they're really trying to figure out whether they should stop scanning the block pool.
If the BPOS is connected to any NN at all (regardless of active/standby) it needs to report
true so that the scanners don't stop running. It would be nice to clean up these calls and
specify in their function name that they're only meant for use in tests" and annotate @VisibleForTesting.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message