Return-Path: X-Original-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 010FE9ED4 for ; Wed, 2 Nov 2011 20:54:27 +0000 (UTC) Received: (qmail 61168 invoked by uid 500); 2 Nov 2011 20:54:27 -0000 Delivered-To: apmail-hadoop-hdfs-dev-archive@hadoop.apache.org Received: (qmail 61045 invoked by uid 500); 2 Nov 2011 20:54:27 -0000 Mailing-List: contact hdfs-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-dev@hadoop.apache.org Delivered-To: mailing list hdfs-dev@hadoop.apache.org Received: (qmail 61029 invoked by uid 99); 2 Nov 2011 20:54:27 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2011 20:54:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 313EE1C08FD; Wed, 2 Nov 2011 20:54:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7779269488161794077==" MIME-Version: 1.0 Subject: Re: Review Request: HDFS-1580: Add interface for generic Write Ahead Logging mechanisms From: "Ivan Kelly" To: "Todd Lipcon" , "Ivan Kelly" , "hadoop-hdfs" Date: Wed, 02 Nov 2011 20:54:27 -0000 Message-ID: <20111102205427.16339.2273@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/2672/ In-Reply-To: <20111102143347.1346.4392@reviews.apache.org> References: <20111102143347.1346.4392@reviews.apache.org> --===============7779269488161794077== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2672/ ----------------------------------------------------------- (Updated 2011-11-02 20:54:27.126053) Review request for hadoop-hdfs. Summary ------- This is the final piece to allow the loading of custom implementations of J= ournalManager. There is another change HDFS-2334 which adds closeable to Jo= urnalManager, but that may not be absolutely necessary for all journal type= s. (it is for bookkeeper) There's 2 changes: 1) I've changes the interfaces(JournalManager, EditLogInputStream & EditLog= OutputStream) so that they can be implemented outside of the org.apache.had= oop.hdfs.server.namenode. 2) Pluggable creation of journal managers. When FSEditLog is creating JournalManagers from dfs.namenode.edits.dir, and= it encounters a URI with a schema different to "file" it loads the name of= the implementing class from "dfs.namenode.edits.journal-plugin.". = This class must implement JournalManager and have a constructor which takes= (Configuration, URI). This addresses bug HDFS-1580. http://issues.apache.org/jira/browse/HDFS-1580 Diffs (updated) ----- hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSC= onfigKeys.java dd39676 = hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/serv= er/namenode/EditLogBackupInputStream.java 974697d = hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/serv= er/namenode/EditLogBackupOutputStream.java 067990d = hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/serv= er/namenode/EditLogFileInputStream.java 9db7f8a = hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/serv= er/namenode/EditLogFileOutputStream.java 4780d04 = hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/serv= er/namenode/EditLogInputStream.java c6f8505 = hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/serv= er/namenode/EditLogOutputStream.java 8681837 = hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/serv= er/namenode/FSEditLog.java f80f863 = hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/serv= er/namenode/FSEditLogLoader.java 991fd08 = hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/serv= er/namenode/FSEditLogOp.java 3adb439 = hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/serv= er/namenode/JournalManager.java 348e3ef = hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/serv= er/namenode/JournalSet.java 45b5714 = hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/serv= er/namenode/NNStorage.java a7fa7fb = hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/serv= er/namenode/NameNodeResourceChecker.java 4d7cfd8 = hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/serv= er/namenode/TestGenericJournalConf.java PRE-CREATION = Diff: https://reviews.apache.org/r/2672/diff Testing ------- Thanks, Ivan --===============7779269488161794077==--