hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Kelly" <iv...@apache.org>
Subject Re: Review Request: HDFS-2334: Add Closeable to JournalManager
Date Thu, 20 Oct 2011 09:00:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2247/
-----------------------------------------------------------

(Updated 2011-10-20 09:00:57.815922)


Review request for hadoop-hdfs.


Summary (updated)
-------

A JournalManager may take hold of resources for the duration of their lifetime. This isn't
the case at the moment for FileJournalManager, but BookKeeperJournalManager will, and it's
conceivable that FileJournalManager could take a lock on a directory etc.

This JIRA is to add Closeable to JournalManager so that these resources can be cleaned up
when FSEditLog is closed.


This addresses bug HDFS-2334.
    http://issues.apache.org/jira/browse/HDFS-2334


Diffs
-----

  hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupJournalManager.java
6976620 
  hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
4a41a2c 
  hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileJournalManager.java
8cfc975 
  hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalManager.java
0bb7b0f 
  hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalSet.java
0d6bc74 

Diff: https://reviews.apache.org/r/2247/diff


Testing
-------


Thanks,

Ivan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message