hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HDFS-164) Startup sanity data directory check in main loop.
Date Sun, 17 Jul 2011 18:54:59 GMT

     [ https://issues.apache.org/jira/browse/HDFS-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Harsh J resolved HDFS-164.
--------------------------

    Resolution: Cannot Reproduce

This appears to be fixed already, as the data directory consistency check is not done for
every xceiver thread.

Not sure on which JIRA it was that fixed/refactored this, however.

Marking as cannot reproduce (anymore). (Btw, this ticket was opened in '06)

> Startup sanity data directory check in main loop.
> -------------------------------------------------
>
>                 Key: HDFS-164
>                 URL: https://issues.apache.org/jira/browse/HDFS-164
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Benjamin Reed
>            Assignee: Sameer Paranjpye
>            Priority: Minor
>
> In the overall scheme of things this is probably a nit, but in the run() method of DataXceiveServer
in DataNode.java the method "data.checkDataDir()" is called right after the socket accept.
data.checkDataDir() is a sanity check that makes sure the data directory is setup properly.
It is a good sanity check to do when the server is started, but it seems like a bit of a waste
to do it after every socket accept. If something happens that causes the sanity check to fail,
you would end up finding out about it during the processing of the request anyway.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message