Return-Path: Delivered-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Received: (qmail 12902 invoked from network); 14 Apr 2011 22:14:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 14 Apr 2011 22:14:46 -0000 Received: (qmail 45055 invoked by uid 500); 14 Apr 2011 22:14:46 -0000 Delivered-To: apmail-hadoop-hdfs-dev-archive@hadoop.apache.org Received: (qmail 44978 invoked by uid 500); 14 Apr 2011 22:14:46 -0000 Mailing-List: contact hdfs-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-dev@hadoop.apache.org Delivered-To: mailing list hdfs-dev@hadoop.apache.org Received: (qmail 44970 invoked by uid 99); 14 Apr 2011 22:14:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Apr 2011 22:14:45 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Apr 2011 22:14:43 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id B221A9A262 for ; Thu, 14 Apr 2011 22:14:05 +0000 (UTC) Date: Thu, 14 Apr 2011 22:14:05 +0000 (UTC) From: "Daryn Sharp (JIRA)" To: hdfs-dev@hadoop.apache.org Message-ID: <1192610044.59054.1302819245726.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Created] (HDFS-1838) More refactoring of BlockReceiver MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org More refactoring of BlockReceiver --------------------------------- Key: HDFS-1838 URL: https://issues.apache.org/jira/browse/HDFS-1838 Project: Hadoop HDFS Issue Type: Bug Components: data-node Affects Versions: 0.23.0 Reporter: Daryn Sharp Assignee: Daryn Sharp While reviewing HDFS-1833 (refactor BlockReceiver), I teased apart the giant run() method into multiple methods to better understand the code. After doing so, the logic begins to appear dubious with possible faulty edge cases. At a minimum, having the method broken down makes the code far more readable to the layman. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira