Return-Path: Delivered-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Received: (qmail 51466 invoked from network); 2 Dec 2010 19:17:59 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 2 Dec 2010 19:17:59 -0000 Received: (qmail 24500 invoked by uid 500); 2 Dec 2010 19:17:59 -0000 Delivered-To: apmail-hadoop-hdfs-dev-archive@hadoop.apache.org Received: (qmail 24407 invoked by uid 500); 2 Dec 2010 19:17:58 -0000 Mailing-List: contact hdfs-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-dev@hadoop.apache.org Delivered-To: mailing list hdfs-dev@hadoop.apache.org Received: (qmail 24399 invoked by uid 99); 2 Dec 2010 19:17:58 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Dec 2010 19:17:58 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=10.0 tests=ALL_TRUSTED,FREEMAIL_FROM,HTML_MESSAGE X-Spam-Check-By: apache.org Received: from [140.211.11.40] (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Dec 2010 19:17:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (8.14.3/8.14.3/Debian-9.1ubuntu1) with ESMTP id oB2JLNq7005538; Thu, 2 Dec 2010 19:21:23 GMT Content-Type: multipart/alternative; boundary="===============7764955411088009872==" MIME-Version: 1.0 Subject: Re: Review Request: Ability to do savenamespace without being in safemode From: "Dhruba Borthakur" To: "Dhruba Borthakur" , "hadoop-hdfs" Date: Thu, 02 Dec 2010 19:21:23 -0000 Message-ID: <20101202192123.31140.88812@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/125/ In-Reply-To: <20101202070501.31140.99047@reviews.apache.org> References: <20101202070501.31140.99047@reviews.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org --===============7764955411088009872== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/125/ ----------------------------------------------------------- (Updated 2010-12-02 11:21:23.394822) Review request for hadoop-hdfs. Changes ------- This addresses Konstanitin's request to add a unit test to test the invocat= ion of saveNamespace command in the middle of a checkpoint. Summary ------- The namenode need not be in safemode while runnign the saveNamespace comman= d. The saveNamespace command acquires the FSNamesystem writelock, thus prev= enting anybody else from modifying the namespace. The lease expiry thread in the LeaseManager acquires the FSNamesystem-write= lock too, so it is well protected. This addresses bug HDFS-1508. https://issues.apache.org/jira/browse/HDFS-1508 Diffs (updated) ----- http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/had= oop/hdfs/DFSClient.java 1041540 = http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/had= oop/hdfs/DistributedFileSystem.java 1041540 = http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/had= oop/hdfs/protocol/ClientProtocol.java 1041540 = http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/had= oop/hdfs/server/namenode/FSNamesystem.java 1041540 = http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/had= oop/hdfs/server/namenode/NameNode.java 1041540 = http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/had= oop/hdfs/tools/DFSAdmin.java 1041540 = http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apach= e/hadoop/hdfs/UpgradeUtilities.java 1041540 = http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apach= e/hadoop/hdfs/server/namenode/TestEditLogRace.java 1041540 = http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apach= e/hadoop/hdfs/server/namenode/TestParallelImageWrite.java 1041540 = http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apach= e/hadoop/hdfs/server/namenode/TestSaveNamespace.java 1041540 = http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apach= e/hadoop/hdfs/server/namenode/TestStartup.java 1041540 = http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apach= e/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java 1041540 = Diff: https://reviews.apache.org/r/125/diff Testing ------- Unit test attached Thanks, Dhruba --===============7764955411088009872==--