hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dhruba Borthakur" <dhr...@gmail.com>
Subject Re: Review Request: Ability to do savenamespace without being in safemode
Date Thu, 02 Dec 2010 19:21:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/125/
-----------------------------------------------------------

(Updated 2010-12-02 11:21:23.394822)


Review request for hadoop-hdfs.


Changes
-------

This addresses Konstanitin's request to add a unit test to test the invocation of saveNamespace
command in the middle of a checkpoint.


Summary
-------

The namenode need not be in safemode while runnign the saveNamespace command. The saveNamespace
command acquires the FSNamesystem writelock, thus preventing anybody else from modifying the
namespace.

The lease expiry thread in the LeaseManager acquires the FSNamesystem-writelock too, so it
is well protected.


This addresses bug HDFS-1508.
    https://issues.apache.org/jira/browse/HDFS-1508


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DFSClient.java
1041540 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
1041540 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
1041540 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
1041540 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
1041540 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
1041540 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/UpgradeUtilities.java
1041540 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestEditLogRace.java
1041540 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestParallelImageWrite.java
1041540 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestSaveNamespace.java
1041540 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestStartup.java
1041540 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
1041540 

Diff: https://reviews.apache.org/r/125/diff


Testing
-------

Unit test attached


Thanks,

Dhruba


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message