Return-Path: Delivered-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Received: (qmail 37628 invoked from network); 3 Nov 2010 18:40:30 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 3 Nov 2010 18:40:30 -0000 Received: (qmail 14916 invoked by uid 500); 3 Nov 2010 18:41:01 -0000 Delivered-To: apmail-hadoop-hdfs-dev-archive@hadoop.apache.org Received: (qmail 14779 invoked by uid 500); 3 Nov 2010 18:40:59 -0000 Mailing-List: contact hdfs-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-dev@hadoop.apache.org Delivered-To: mailing list hdfs-dev@hadoop.apache.org Received: (qmail 14771 invoked by uid 99); 3 Nov 2010 18:40:59 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Nov 2010 18:40:59 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=10.0 tests=ALL_TRUSTED,FREEMAIL_FROM,HTML_MESSAGE X-Spam-Check-By: apache.org Received: from [140.211.11.40] (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Nov 2010 18:40:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (8.14.3/8.14.3/Debian-9.1ubuntu1) with ESMTP id oA3IfdDw005386; Wed, 3 Nov 2010 18:41:39 GMT Content-Type: multipart/alternative; boundary="===============6749877079211934350==" MIME-Version: 1.0 Subject: Re: Review Request: DFSClient.getBlockLocations returns BlockLocations with no indication that the corresponding blocks are corrupt From: "Ramkumar Vadali" To: "Patrick Kling" , "Ramkumar Vadali" , "hadoop-hdfs" Date: Wed, 03 Nov 2010 18:41:39 -0000 Message-ID: <20101103184139.28431.68045@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/27/ In-Reply-To: <20101103183339.28430.61728@reviews.apache.org> References: <20101103183339.28430.61728@reviews.apache.org> --===============6749877079211934350== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27/#review29 ----------------------------------------------------------- Looks good to me, but this diff depends on a hadoop-common change, right? - Ramkumar On 2010-11-03 11:33:39, Patrick Kling wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27/ > ----------------------------------------------------------- > = > (Updated 2010-11-03 11:33:39) > = > = > Review request for hadoop-hdfs. > = > = > Summary > ------- > = > DFSClient.getBlockLocations returns BlockLocations with no indication tha= t the corresponding blocks are corrupt > = > When there are no uncorrupted replicas of a block, FSNamesystem.getBlockL= ocations returns LocatedBlocks corresponding to corrupt blocks. When DFSCli= ent converts these to BlockLocations, the information that the correspondin= g block is corrupt is lost. We should add a field to BlockLocation to indic= ate whether the corresponding block is corrupt in order to warn the client = that reading this block will fail. This would be especially useful for tool= s such as RAID FSCK, which could then easily inspect whether data or parity= blocks are corrupted without having to make direct RPC calls > = > = > This addresses bug HDFS-1483. > https://issues.apache.org/jira/browse/HDFS-1483 > = > = > Diffs > ----- > = > http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/h= adoop/hdfs/DFSUtil.java 1028386 = > http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apa= che/hadoop/hdfs/TestDFSUtil.java PRE-CREATION = > = > Diff: https://reviews.apache.org/r/27/diff > = > = > Testing > ------- > = > TestDFSUtil > = > = > Thanks, > = > Patrick > = > --===============6749877079211934350==--