Return-Path: Delivered-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Received: (qmail 20945 invoked from network); 1 Nov 2010 18:49:39 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 1 Nov 2010 18:49:39 -0000 Received: (qmail 94384 invoked by uid 500); 1 Nov 2010 18:50:11 -0000 Delivered-To: apmail-hadoop-hdfs-dev-archive@hadoop.apache.org Received: (qmail 94282 invoked by uid 500); 1 Nov 2010 18:50:10 -0000 Mailing-List: contact hdfs-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-dev@hadoop.apache.org Delivered-To: mailing list hdfs-dev@hadoop.apache.org Received: (qmail 94274 invoked by uid 99); 1 Nov 2010 18:50:10 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 18:50:10 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=10.0 tests=ALL_TRUSTED,HTML_MESSAGE X-Spam-Check-By: apache.org Received: from [140.211.11.40] (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 18:50:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (8.14.3/8.14.3/Debian-9.1ubuntu1) with ESMTP id oA1IobEs032459; Mon, 1 Nov 2010 18:50:37 GMT Content-Type: multipart/alternative; boundary="===============2190536087266346390==" MIME-Version: 1.0 Subject: Re: Review Request: Add listCorruptFileBlocks to DistributedFileSystem (and ClientProtocol) From: "Patrick Kling" To: "Dhruba Borthakur" , "Patrick Kling" , "hadoop-hdfs" Date: Mon, 01 Nov 2010 18:50:37 -0000 Message-ID: <20101101185037.28430.86810@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/18/ In-Reply-To: <20101029165028.27680.27158@reviews.apache.org> References: <20101029165028.27680.27158@reviews.apache.org> --===============2190536087266346390== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18/ ----------------------------------------------------------- (Updated 2010-11-01 11:50:37.134842) Review request for hadoop-hdfs. Changes ------- ClientProtocol.listCorruptFileBlocks now returns a list of file names and a= cookie string, which can be used to iteratively retrieve all corrupt files. Summary ------- Add listCorruptFileBlocks to DistributedFileSystem (and ClientProtocol) As discussed in HDFS-1111, it would be beneficial for tools such as the RAI= D block fixer and RAID FSCK to have access to listCorruptFileBlocks via the= DistributedFileSystem (rather than having to parse Servlet output, which c= ould present a performance problem). For further details, see https://issues.apache.org/jira/browse/HDFS-1482 This addresses bug HDFS-1482. https://issues.apache.org/jira/browse/HDFS-1482 Diffs (updated) ----- http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/had= oop/hdfs/DFSClient.java 1028517 = http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/had= oop/hdfs/DistributedFileSystem.java 1028517 = http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/had= oop/hdfs/protocol/ClientProtocol.java 1028517 = http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/had= oop/hdfs/protocol/CorruptFileBlocks.java PRE-CREATION = http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/had= oop/hdfs/server/namenode/NameNode.java 1028517 = http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/had= oop/hdfs/server/namenode/NamenodeFsck.java 1028517 = http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apach= e/hadoop/hdfs/server/namenode/TestCorruptFilesJsp.java 1028517 = http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apach= e/hadoop/hdfs/server/namenode/TestFsck.java 1028517 = http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apach= e/hadoop/hdfs/server/namenode/TestListCorruptFileBlocks.java 1028517 = http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/webapps/hdfs/corrup= t_files.jsp 1028517 = Diff: https://reviews.apache.org/r/18/diff Testing ------- Unit tests (including new test case in TestListCorruptFileBlocks) Thanks, Patrick --===============2190536087266346390==--