hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dhruba Borthakur" <dhr...@gmail.com>
Subject Review Request: Ability to do savenamespace without being in safemode
Date Tue, 30 Nov 2010 19:56:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/125/
-----------------------------------------------------------

Review request for hadoop-hdfs.


Summary
-------

The namenode need not be in safemode while runnign the saveNamespace command. The saveNamespace
command acquires the FSNamesystem writelock, thus preventing anybody else from modifying the
namespace.

The lease expiry thread in the LeaseManager acquires the FSNamesystem-writelock too, so it
is well protected.


This addresses bug HDFS-1508.
    https://issues.apache.org/jira/browse/HDFS-1508


Diffs
-----

  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
1040699 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestSaveNamespace.java
1040699 

Diff: https://reviews.apache.org/r/125/diff


Testing
-------

Unit test attached


Thanks,

Dhruba


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message