hadoop-hdfs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Kling" <pkl...@cs.uwaterloo.ca>
Subject Re: Review Request: Add listCorruptFileBlocks to DistributedFileSystem (and ClientProtocol)
Date Mon, 01 Nov 2010 18:50:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18/
-----------------------------------------------------------

(Updated 2010-11-01 11:50:37.134842)


Review request for hadoop-hdfs.


Changes
-------

ClientProtocol.listCorruptFileBlocks now returns a list of file names and a cookie string,
which can be used to iteratively retrieve all corrupt files.


Summary
-------

Add listCorruptFileBlocks to DistributedFileSystem (and ClientProtocol)

As discussed in HDFS-1111, it would be beneficial for tools such as the RAID block fixer and
RAID FSCK to have access to listCorruptFileBlocks via the DistributedFileSystem (rather than
having to parse Servlet output, which could present a performance problem).

For further details, see https://issues.apache.org/jira/browse/HDFS-1482


This addresses bug HDFS-1482.
    https://issues.apache.org/jira/browse/HDFS-1482


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DFSClient.java
1028517 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
1028517 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
1028517 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/protocol/CorruptFileBlocks.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
1028517 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
1028517 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestCorruptFilesJsp.java
1028517 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestFsck.java
1028517 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestListCorruptFileBlocks.java
1028517 
  http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/webapps/hdfs/corrupt_files.jsp 1028517


Diff: https://reviews.apache.org/r/18/diff


Testing
-------

Unit tests (including new test case in TestListCorruptFileBlocks)


Thanks,

Patrick


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message