From hdfs-dev-return-223-apmail-hadoop-hdfs-dev-archive=hadoop.apache.org@hadoop.apache.org Wed Sep 02 21:48:57 2009 Return-Path: Delivered-To: apmail-hadoop-hdfs-dev-archive@minotaur.apache.org Received: (qmail 37555 invoked from network); 2 Sep 2009 21:48:57 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 2 Sep 2009 21:48:57 -0000 Received: (qmail 19405 invoked by uid 500); 2 Sep 2009 21:48:56 -0000 Delivered-To: apmail-hadoop-hdfs-dev-archive@hadoop.apache.org Received: (qmail 19300 invoked by uid 500); 2 Sep 2009 21:48:56 -0000 Mailing-List: contact hdfs-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-dev@hadoop.apache.org Delivered-To: mailing list hdfs-dev@hadoop.apache.org Received: (qmail 19280 invoked by uid 99); 2 Sep 2009 21:48:56 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Sep 2009 21:48:56 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Sep 2009 21:48:53 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id C64D3234C04B for ; Wed, 2 Sep 2009 14:48:32 -0700 (PDT) Message-ID: <1500325196.1251928112811.JavaMail.jira@brutus> Date: Wed, 2 Sep 2009 14:48:32 -0700 (PDT) From: "Konstantin Boudnik (JIRA)" To: hdfs-dev@hadoop.apache.org Subject: [jira] Resolved: (HDFS-584) Fail the fault-inject build if any advices are mis-bound In-Reply-To: <1924435858.1251850533157.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Boudnik resolved HDFS-584. ------------------------------------- Resolution: Won't Fix It turns out that mis-bound warnings couldn't be simply turned into errors, because this is default behavior of AJC and I don't see a way to configure it differently. The only possibility is to intercept the compiler output and parse it in order to find if any warnings were produced and abort the build in that case. But it seems to be too much trouble to do so. Another possibility is to extend {{test-patch}} so it will verify that a new patch doesn't increase the number of AJC warnings like it currently does for javac. > Fail the fault-inject build if any advices are mis-bound > -------------------------------------------------------- > > Key: HDFS-584 > URL: https://issues.apache.org/jira/browse/HDFS-584 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Konstantin Boudnik > Assignee: Konstantin Boudnik > > Whenever AspectJ compiler can't bind an advice it issues a warning message, but the build process isn't failing because of it. > The build has to fail though, because mis-bound advices lead to failing tests which are hard to explain otherwise. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.